jalil/webnsupdate
1
0
Fork 0
Code Issues 2 Pull requests 3 Releases Activity Actions

feat(webnsupdate): add handling for multiple IPs #71

Merged
jalil merged 1 commit from push-ksurkrqwwxpl into main 2025-01-23 21:31:37 +01:00
Conversation 1 Commits 1 Files changed 3 +83 -31
jalil commented 2025-01-23 21:27:48 +01:00
Owner
Copy link

Specifically, for when both and IPv6 and and IPv4 addr is provided. This ensures we can forward both addrs to webnsupdate, instead of only allowing IPv4.

Specifically, for when both and IPv6 and and IPv4 addr is provided. This ensures we can forward both addrs to webnsupdate, instead of only allowing IPv4.
jalil self-assigned this 2025-01-23 21:27:48 +01:00
jalil added 1 commit 2025-01-23 21:27:48 +01:00
feat(webnsupdate): add handling for multiple IPs
All checks were successful
/ build (push) Successful in 1s
Details
/ check (push) Successful in 8s
Details
/ report-size (push) Successful in 2s
Details
a2735b46b5 
Specifically, for when both and IPv6 and and IPv4 addr is provided. This
ensures we can forward both addrs to webnsupdate, instead of only
allowing IPv4.
forgejo-actions commented 2025-01-23 21:29:27 +01:00
First-time contributor
Copy link

Flake output sizes

Definitions:

  • Name: the name of the package/configuration.
  • Size: the closure size (size on disk/NAR size + all transitive dependencies).
  • NAR Size: the size of the build output (package without the dependencies).
  • [NAR] Size Change: the amount changed compared to the main branch.

Tips on reading this data:

  • For NixOS configurations you generally care only about the Size (closure size/size on disk).
    • Reduce the Size by disabling unneeded services/default packages.
  • For Packages you care about both the Size and the NAR Size.
    • Reduce the NAR Size by reducing the size of the build outputs, e.g. don't copy unnecessary data to the $out dir, optimize binaries for size, etc.
    • Reduce the Size by reducing the dependencies (e.g. buildInputs).
    • Don't worry too much about size, some dependencies are deduplicated, e.g. glibc adds ~40MiB to the Size, but is generally shared by ~every binary on the system, so, chances are, you are already including it from somewhere else and statically linking with e.g. musl is not gonna improve things.

Packages

Name Size Size Change NAR Size NAR Size Change
default 35MiB 49KiB 2.9MiB 49KiB
git-cliff 60MiB 0B 19MiB 0B
webnsupdate 35MiB 49KiB 2.9MiB 49KiB
# Flake output sizes **Definitions:** - `Name`: the name of the package/configuration. - `Size`: the closure size (size on disk/NAR size + all transitive dependencies). - `NAR Size`: the size of the build output (package without the dependencies). - `[NAR] Size Change`: the amount changed compared to the main branch. **Tips on reading this data:** - For NixOS configurations you generally care only about the `Size` (closure size/size on disk). - Reduce the `Size` by disabling unneeded services/default packages. - For Packages you care about both the `Size` and the `NAR Size`. - Reduce the `NAR Size` by reducing the size of the build outputs, e.g. don't copy unnecessary data to the $out dir, optimize binaries for size, etc. - Reduce the `Size` by reducing the dependencies (e.g. `buildInputs`). - Don't worry too much about size, some dependencies are deduplicated, e.g. `glibc` adds ~40MiB to the `Size`, but is generally shared by ~every binary on the system, so, chances are, you are already including it from somewhere else and statically linking with e.g. `musl` is not gonna improve things. # Packages | Name | Size | Size Change | NAR Size | NAR Size Change | |------|-----:|------------:|---------:|----------------:| | `default` | 35MiB | 49KiB | 2.9MiB | 49KiB | | `git-cliff` | 60MiB | 0B | 19MiB | 0B | | `webnsupdate` | 35MiB | 49KiB | 2.9MiB | 49KiB |
jalil merged commit a2735b46b5 into main 2025-01-23 21:31:37 +01:00
jalil deleted branch push-ksurkrqwwxpl 2025-01-23 21:31:37 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
jalil
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jalil/webnsupdate#71
No description provided.
Delete branch "push-ksurkrqwwxpl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?