jalil/webnsupdate
1
1
Fork 0
Code Issues 1 Pull requests 4 Releases 1 Packages 1 Activity Actions

refactor(config)!: change config format a bit #419

Open
jalil wants to merge 1 commit from push-poorwyxwqvur into main
pull from: push-poorwyxwqvur
merge into: jalil:main
Conversation 1 Commits 1 Files changed 15 +1567 -870
jalil commented 2025-09-04 23:41:17 +02:00
Owner
Copy link

This way we can extend it a bit easier. Also, I kinda dislike serde(flatten).

This way we can extend it a bit easier. Also, I kinda dislike `serde(flatten)`.
jalil self-assigned this 2025-09-04 23:41:17 +02:00
refactor(config)!: change config format a bit
All checks were successful
/ build (pull_request) Successful in 19s
Details
/ checks (x86_64-linux, clippy) (pull_request) Successful in 12s
Details
/ checks (x86_64-linux, deny) (pull_request) Successful in 4s
Details
/ checks (x86_64-linux, module-ipv4-only-test) (pull_request) Successful in 32s
Details
/ checks (x86_64-linux, module-ipv4-test) (pull_request) Successful in 31s
Details
/ checks (x86_64-linux, module-ipv6-only-test) (pull_request) Successful in 32s
Details
/ checks (x86_64-linux, module-ipv6-test) (pull_request) Successful in 31s
Details
/ checks (x86_64-linux, module-nginx-test) (pull_request) Successful in 34s
Details
/ checks (x86_64-linux, nextest) (pull_request) Successful in 3s
Details
/ checks (x86_64-linux, treefmt) (pull_request) Successful in 3s
Details
/ trigger-release (pull_request) Successful in 21s
Details
/ report-size (pull_request) Successful in 7s
Details
ed5fb2430f
 
This way we can extend it a bit easier. Also, I kinda dislike
`serde(flatten)`.
forgejo-actions commented 2025-09-04 23:44:49 +02:00
Copy link

Flake output sizes

Definitions
  • Name: the name of the package/configuration.
  • Size: the closure size (size on disk/NAR size + all transitive dependencies).
  • NAR Size: the size of the build output (package without the dependencies).
  • [NAR] Size Change: the amount changed compared to the main branch.
Tips on reading this data
  • For NixOS/Home-Manager configurations you generally care only about the Size (closure size/size on disk).
    • Reduce the Size by disabling unneeded services/default packages.
  • For Packages you care about both the Size and the NAR Size.
    • Reduce the NAR Size by reducing the size of the build outputs, e.g. don't copy unnecessary data to the $out dir, optimize binaries for size, etc.
    • Reduce the Size by reducing the dependencies (e.g. buildInputs).
    • Don't worry too much about size, some dependencies are deduplicated, e.g. glibc adds ~40MiB to the Size, but is generally shared by ~every binary on the system, so, chances are, you are already including it from somewhere else and statically linking with e.g. musl is not gonna improve things.

NixOS Configurations

Name Size Size Change NAR Size NAR Size Change

Home Manager Configurations

Name Size Size Change NAR Size NAR Size Change

Packages

Name Size Size Change NAR Size NAR Size Change
webnsupdate 34MiB 26KiB 2.2MiB 26KiB
<!-- AUTOGENERATED by nix-flake-outputs-size action --> ## Flake output sizes <details><summary><b>Definitions</b></summary> - `Name`: the name of the package/configuration. - `Size`: the closure size (size on disk/NAR size + all transitive dependencies). - `NAR Size`: the size of the build output (package without the dependencies). - `[NAR] Size Change`: the amount changed compared to the main branch. </details> <details><summary><b>Tips on reading this data</b></summary> - For NixOS/Home-Manager configurations you generally care only about the `Size` (closure size/size on disk). - Reduce the `Size` by disabling unneeded services/default packages. - For Packages you care about both the `Size` and the `NAR Size`. - Reduce the `NAR Size` by reducing the size of the build outputs, e.g. don't copy unnecessary data to the $out dir, optimize binaries for size, etc. - Reduce the `Size` by reducing the dependencies (e.g. `buildInputs`). - Don't worry too much about size, some dependencies are deduplicated, e.g. `glibc` adds ~40MiB to the `Size`, but is generally shared by ~every binary on the system, so, chances are, you are already including it from somewhere else and statically linking with e.g. `musl` is not gonna improve things. </details> ## NixOS Configurations | Name | Size | Size Change | NAR Size | NAR Size Change | |------|-----:|------------:|---------:|----------------:| ## Home Manager Configurations | Name | Size | Size Change | NAR Size | NAR Size Change | |------|-----:|------------:|---------:|----------------:| ## Packages | Name | Size | Size Change | NAR Size | NAR Size Change | |------|-----:|------------:|---------:|----------------:| | `webnsupdate` | 34MiB | 26KiB | 2.2MiB | 26KiB |
jalil force-pushed push-poorwyxwqvur from ed5fb2430f to 01b629642d 2025-09-06 18:45:43 +02:00 Compare
jalil force-pushed push-poorwyxwqvur from 01b629642d to 6878ec7a1b 2025-09-08 00:15:02 +02:00 Compare
jalil force-pushed push-poorwyxwqvur from 6878ec7a1b to 14b1cd1fa8 2025-09-08 20:31:13 +02:00 Compare
jalil force-pushed push-poorwyxwqvur from 14b1cd1fa8 to 4a096c8c3f 2025-09-08 20:40:42 +02:00 Compare
All checks were successful
/ build (pull_request) Successful in 3s
Required
Details
/ checks (x86_64-linux, clippy) (pull_request) Successful in 3s
Required
Details
/ checks (x86_64-linux, deny) (pull_request) Successful in 3s
Required
Details
/ checks (x86_64-linux, module-ipv4-only-test) (pull_request) Successful in 28s
Required
Details
/ checks (x86_64-linux, module-ipv4-test) (pull_request) Successful in 28s
Required
Details
/ checks (x86_64-linux, module-ipv6-only-test) (pull_request) Successful in 28s
Required
Details
/ checks (x86_64-linux, module-ipv6-test) (pull_request) Successful in 28s
Required
Details
/ checks (x86_64-linux, module-nginx-test) (pull_request) Successful in 29s
Required
Details
/ checks (x86_64-linux, nextest) (pull_request) Successful in 3s
Required
Details
/ checks (x86_64-linux, treefmt) (pull_request) Successful in 3s
Required
Details
/ trigger-release (pull_request) Successful in 26s
Required
Details
/ report-size (pull_request) Successful in 5s
Required
Details
This pull request is blocked because it's outdated.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin push-poorwyxwqvur:push-poorwyxwqvur
git switch push-poorwyxwqvur
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
chore

Cleanup/trivial updates

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
release

A PR created by `release-plz`

  
wontfix

This won't be fixed

No labels
bug
chore
duplicate
enhancement
help wanted
invalid
question
release
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
jalil
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jalil/webnsupdate#419
No description provided.
Delete branch "push-poorwyxwqvur"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?