Compare commits

..

1 commit

Author SHA1 Message Date
c68e4deaad
ci: test both push and pull_request events
Some checks failed
/ check (treefmt) (pull_request) Successful in 24s
/ report-size-push (pull_request) Failing after 1s
/ report-size-pr (pull_request) Failing after 2s
/ report-download-check-push (pull_request) Failing after 1s
/ report-download-check-pr (pull_request) Failing after 1s
I think we have a bug with pull_request events so...
2025-07-10 19:40:14 +02:00
2 changed files with 39 additions and 36 deletions

View file

@ -1,5 +1,7 @@
on: on:
push: push:
branches: [main]
pull_request:
jobs: jobs:
check: check:
runs-on: nixos runs-on: nixos
@ -14,9 +16,10 @@ jobs:
nix --version nix --version
# shellcheck disable=SC2016 # shellcheck disable=SC2016
nix build --print-build-logs '.#checks.x86_64-linux.${{ matrix.check }}' nix build --print-build-logs '.#checks.x86_64-linux.${{ matrix.check }}'
report-size: report-size-push:
runs-on: nixos runs-on: nixos
needs: check needs: check
if: github.event_name == 'push'
steps: steps:
- uses: "https://git.salame.cl/actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683" # v4 - uses: "https://git.salame.cl/actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683" # v4
- run: nix --version - run: nix --version
@ -30,8 +33,29 @@ jobs:
# Always generate artifacts for testing purposes # Always generate artifacts for testing purposes
generate-artifact: 'true' generate-artifact: 'true'
# This job's name (so we can find the previous artifacts) # This job's name (so we can find the previous artifacts)
job-name: report-size job-name: report-size-push
report-download-check: report-size-pr:
runs-on: nixos
needs: check
if: github.event_name == 'pull_request'
steps:
- uses: "https://git.salame.cl/actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683" # v4
- run: nix --version
- name: Create Size Report
uses: ./
with:
# Create a comment on the associated PR
comment-on-pr: 'true'
# Generate artifacts on main (to speed up comparisons)
# generate-artifact: ${{ github.ref_name == 'main' }}
# Always generate artifacts for testing purposes
generate-artifact: 'true'
# Generate comparisons to main
do-comparison: 'true'
# Get the previous artifacts from report-size-push (since those run on main)
job-name: report-size-push
artifact-name: report-pr.json
report-download-check-push:
runs-on: nixos runs-on: nixos
needs: report-size-push needs: report-size-push
if: github.event_name == 'push' if: github.event_name == 'push'
@ -43,3 +67,15 @@ jobs:
- name: Verify report exists - name: Verify report exists
run: | run: |
cat report.json cat report.json
report-download-check-pr:
runs-on: nixos
needs: report-size-pr
if: github.event_name == 'pull_request'
steps:
- name: Download previous report
uses: https://git.salame.cl/actions/download-artifact@d8d0a99033603453ad2255e58720b460a0555e1e # v4
with:
name: report-pr.json
- name: Verify report exists
run: |
cat report-pr.json

View file

@ -1,33 +0,0 @@
on:
pull_request:
jobs:
report-size-pr:
runs-on: nixos
steps:
- uses: "https://git.salame.cl/actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683" # v4
- run: nix --version
- name: Create Size Report
uses: ./
with:
# Create a comment on the associated PR
comment-on-pr: 'true'
# Generate artifacts on main (to speed up comparisons)
# generate-artifact: ${{ github.ref_name == 'main' }}
# Always generate artifacts for testing purposes
generate-artifact: 'true'
# Generate comparisons to main
do-comparison: 'true'
# Get the previous artifacts from report-size-push (since those run on main)
job-name: report-size
artifact-name: report.json
report-download-check-pr:
runs-on: nixos
needs: report-size-pr
steps:
- name: Download previous report
uses: https://git.salame.cl/actions/download-artifact@d8d0a99033603453ad2255e58720b460a0555e1e # v4
with:
name: report.json
- name: Verify report exists
run: |
cat report.json