ci: test both push and pull_request events
Some checks failed
/ report-size-pr (pull_request) Failing after 1s
/ report-download-check-pr (pull_request) Has been skipped
/ check (treefmt) (push) Successful in 4s
/ report-size (push) Successful in 4s
/ report-download-check (push) Successful in 1s

I think we have a bug with pull_request events so...
This commit is contained in:
Jalil David Salamé Messina 2025-07-10 19:39:36 +02:00
parent 838f205020
commit 70de79bafa
Signed by: jalil
GPG key ID: F016B9E770737A0B
2 changed files with 37 additions and 5 deletions

View file

@ -24,18 +24,17 @@ jobs:
uses: ./
with:
# Create a comment on the associated PR
comment-on-pr: ${{ github.ref_name != 'main' }}
comment-on-pr: 'false'
# Generate artifacts on main (to speed up comparisons)
# generate-artifact: ${{ github.ref_name == 'main' }}
# Always generate artifacts for testing purposes
generate-artifact: 'true'
# Generate comparisons to main
do-comparison: 'true'
# This job's name (so we can find the artifacts)
# This job's name (so we can find the previous artifacts)
job-name: report-size
report-download-check:
runs-on: nixos
needs: report-size
needs: report-size-push
if: github.event_name == 'push'
steps:
- name: Download previous report
uses: https://git.salame.cl/actions/download-artifact@d8d0a99033603453ad2255e58720b460a0555e1e # v4

View file

@ -0,0 +1,33 @@
on:
pull_request:
jobs:
report-size-pr:
runs-on: nixos
steps:
- uses: "https://git.salame.cl/actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683" # v4
- run: nix --version
- name: Create Size Report
uses: ./
with:
# Create a comment on the associated PR
comment-on-pr: 'true'
# Generate artifacts on main (to speed up comparisons)
# generate-artifact: ${{ github.ref_name == 'main' }}
# Always generate artifacts for testing purposes
generate-artifact: 'true'
# Generate comparisons to main
do-comparison: 'true'
# Get the previous artifacts from report-size-push (since those run on main)
job-name: report-size
artifact-name: report.json
report-download-check-pr:
runs-on: nixos
needs: report-size-pr
steps:
- name: Download previous report
uses: https://git.salame.cl/actions/download-artifact@d8d0a99033603453ad2255e58720b460a0555e1e # v4
with:
name: report.json
- name: Verify report exists
run: |
cat report.json