fix: disable combinePlugins due to upstream issue #404

Merged

jalil merged 1 commit from push-pypotzuyvxtm into main

2025-04-09 17:58:25 +02:00

jalil commented

2025-04-09 17:42:52 +02:00

Owner

It is experimental (and thus expected to break). It was working fine but now I ran into https://github.com/nix-community/nixvim/issues/3140

jalil added the

bug

label 2025-04-09 17:42:52 +02:00

jalil self-assigned this 2025-04-09 17:42:52 +02:00

jalil added 1 commit 2025-04-09 17:42:53 +02:00

fix: disable combinePlugins due to upstream issue

/ check (push) Successful in 41s

Details

/ check-renovaterc (push) Successful in 3s

Details

/ build-packages (push) Successful in 40s

Details

/ build-vm (push) Successful in 18s

Details

/ report-size (push) Successful in 1m6s

Details

c4e6beb50d

It is experimental (and thus expected to break). It was working fine but
now I ran into https://github.com/nix-community/nixvim/issues/3140

forgejo-actions commented

2025-04-09 17:47:38 +02:00

First-time contributor

Flake output sizes

Definitions

Name: the name of the package/configuration.
Size: the closure size (size on disk/NAR size + all transitive dependencies).
NAR Size: the size of the build output (package without the dependencies).
[NAR] Size Change: the amount changed compared to the main branch.

Tips on reading this data

For NixOS configurations you generally care only about the Size (closure size/size on disk).
- Reduce the Size by disabling unneeded services/default packages.
For Packages you care about both the Size and the NAR Size.
- Reduce the NAR Size by reducing the size of the build outputs, e.g. don't copy unnecessary data to the $out dir, optimize binaries for size, etc.
- Reduce the Size by reducing the dependencies (e.g. buildInputs).
- Don't worry too much about size, some dependencies are deduplicated, e.g. glibc adds ~40MiB to the Size, but is generally shared by ~every binary on the system, so, chances are, you are already including it from somewhere else and statically linking with e.g. musl is not gonna improve things.

NixOS Configurations

Name	Size	Size Change	NAR Size	NAR Size Change
`vm`	9.1GiB	0B	19KiB	0B

Packages

Name	Size	Size Change	NAR Size	NAR Size Change
`audiomenu`	42MiB	0B	1.4MiB	0B
`docs`	3.1MiB	0B	3.1MiB	0B
`docs-home-markdown`	11KiB	0B	11KiB	0B
`docs-nixos-markdown`	6.5KiB	0B	6.5KiB	0B
`docs-nvim-markdown`	2.4KiB	0B	2.4KiB	0B
`jpassmenu`	43MiB	0B	2.3MiB	0B
`nvim`	1.6GiB	86KiB	626KiB	0B
`nvim-headless`	442MiB	-27KiB	626KiB	0B
`nvim-no-lsps`	1.2GiB	-23KiB	626KiB	0B
`nvim-no-ts`	1.7GiB	-23KiB	626KiB	0B
`nvim-small`	1000MiB	86KiB	626KiB	0B
`search`	727KiB	0B	9.0KiB	0B

## Flake output sizes <details><summary><b>Definitions</b></summary> - `Name`: the name of the package/configuration. - `Size`: the closure size (size on disk/NAR size + all transitive dependencies). - `NAR Size`: the size of the build output (package without the dependencies). - `[NAR] Size Change`: the amount changed compared to the main branch. </details> <details><summary><b>Tips on reading this data</b></summary> - For NixOS configurations you generally care only about the `Size` (closure size/size on disk). - Reduce the `Size` by disabling unneeded services/default packages. - For Packages you care about both the `Size` and the `NAR Size`. - Reduce the `NAR Size` by reducing the size of the build outputs, e.g. don't copy unnecessary data to the $out dir, optimize binaries for size, etc. - Reduce the `Size` by reducing the dependencies (e.g. `buildInputs`). - Don't worry too much about size, some dependencies are deduplicated, e.g. `glibc` adds ~40MiB to the `Size`, but is generally shared by ~every binary on the system, so, chances are, you are already including it from somewhere else and statically linking with e.g. `musl` is not gonna improve things. </details> ## NixOS Configurations | Name | Size | Size Change | NAR Size | NAR Size Change | |------|-----:|------------:|---------:|----------------:| | `vm` | 9.1GiB | 0B | 19KiB | 0B | ## Packages | Name | Size | Size Change | NAR Size | NAR Size Change | |------|-----:|------------:|---------:|----------------:| | `audiomenu` | 42MiB | 0B | 1.4MiB | 0B | | `docs` | 3.1MiB | 0B | 3.1MiB | 0B | | `docs-home-markdown` | 11KiB | 0B | 11KiB | 0B | | `docs-nixos-markdown` | 6.5KiB | 0B | 6.5KiB | 0B | | `docs-nvim-markdown` | 2.4KiB | 0B | 2.4KiB | 0B | | `jpassmenu` | 43MiB | 0B | 2.3MiB | 0B | | `nvim` | 1.6GiB | 86KiB | 626KiB | 0B | | `nvim-headless` | 442MiB | -27KiB | 626KiB | 0B | | `nvim-no-lsps` | 1.2GiB | -23KiB | 626KiB | 0B | | `nvim-no-ts` | 1.7GiB | -23KiB | 626KiB | 0B | | `nvim-small` | 1000MiB | 86KiB | 626KiB | 0B | | `search` | 727KiB | 0B | 9.0KiB | 0B |

jalil force-pushed push-pypotzuyvxtm from c4e6beb50d to 486ae7713e

2025-04-09 17:55:37 +02:00

Compare

jalil scheduled this pull request to auto merge when all checks succeed 2025-04-09 17:55:47 +02:00

jalil merged commit 486ae7713e into main

2025-04-09 17:58:25 +02:00

jalil deleted branch push-pypotzuyvxtm

2025-04-09 17:58:25 +02:00