jalil/webnsupdate
1
0
Fork 0
Code Issues 2 Pull requests 1 Releases Activity Actions

Handle empty query params properly #90

Merged
jalil merged 2 commits from push-xurxqrnozzrp into main 2025-01-31 21:21:04 +01:00
Conversation 1 Commits 2 Files changed 2 +22 -4
jalil commented 2025-01-31 21:19:23 +01:00
Owner
Copy link

FRITZ!Box generates empty query params (e.g. /update?ipv4=&ipv6=::1) when only one IP is updated. This handles that properly.

FRITZ!Box generates empty query params (e.g. `/update?ipv4=&ipv6=::1`) when only one IP is updated. This handles that properly.
jalil self-assigned this 2025-01-31 21:19:23 +01:00
jalil added 2 commits 2025-01-31 21:19:23 +01:00 
This happens when one of the IPs hasn't changed (but the other has) in
the FRITZ!Box DDNS client.
fix(tests): add case for when query has empty string
Some checks failed
/ build (push) Successful in 1s
Details
/ check (clippy) (push) Successful in 2s
Details
/ check (module-ipv4-only-test) (push) Successful in 7s
Details
/ check (module-ipv4-test) (push) Successful in 7s
Details
/ check (module-ipv6-only-test) (push) Failing after 15s
Details
/ check (module-ipv6-test) (push) Failing after 15s
Details
/ check (module-nginx-test) (push) Failing after 15s
Details
/ check (nextest) (push) Successful in 2s
Details
/ check (treefmt) (push) Successful in 3s
Details
/ report-size (push) Successful in 1s
Details
bf8c16f565 
This is produced by the FRITZ!Box DDNS client.
jalil scheduled this pull request to auto merge when all checks succeed 2025-01-31 21:19:36 +01:00
forgejo-actions commented 2025-01-31 21:21:02 +01:00
First-time contributor
Copy link

Flake output sizes

Definitions:

  • Name: the name of the package/configuration.
  • Size: the closure size (size on disk/NAR size + all transitive dependencies).
  • NAR Size: the size of the build output (package without the dependencies).
  • [NAR] Size Change: the amount changed compared to the main branch.

Tips on reading this data:

  • For NixOS configurations you generally care only about the Size (closure size/size on disk).
    • Reduce the Size by disabling unneeded services/default packages.
  • For Packages you care about both the Size and the NAR Size.
    • Reduce the NAR Size by reducing the size of the build outputs, e.g. don't copy unnecessary data to the $out dir, optimize binaries for size, etc.
    • Reduce the Size by reducing the dependencies (e.g. buildInputs).
    • Don't worry too much about size, some dependencies are deduplicated, e.g. glibc adds ~40MiB to the Size, but is generally shared by ~every binary on the system, so, chances are, you are already including it from somewhere else and statically linking with e.g. musl is not gonna improve things.

Packages

Name Size Size Change NAR Size NAR Size Change
default 35MiB 720B 2.8MiB 720B
git-cliff 60MiB 0B 19MiB 0B
webnsupdate 35MiB 720B 2.8MiB 720B
# Flake output sizes **Definitions:** - `Name`: the name of the package/configuration. - `Size`: the closure size (size on disk/NAR size + all transitive dependencies). - `NAR Size`: the size of the build output (package without the dependencies). - `[NAR] Size Change`: the amount changed compared to the main branch. **Tips on reading this data:** - For NixOS configurations you generally care only about the `Size` (closure size/size on disk). - Reduce the `Size` by disabling unneeded services/default packages. - For Packages you care about both the `Size` and the `NAR Size`. - Reduce the `NAR Size` by reducing the size of the build outputs, e.g. don't copy unnecessary data to the $out dir, optimize binaries for size, etc. - Reduce the `Size` by reducing the dependencies (e.g. `buildInputs`). - Don't worry too much about size, some dependencies are deduplicated, e.g. `glibc` adds ~40MiB to the `Size`, but is generally shared by ~every binary on the system, so, chances are, you are already including it from somewhere else and statically linking with e.g. `musl` is not gonna improve things. # Packages | Name | Size | Size Change | NAR Size | NAR Size Change | |------|-----:|------------:|---------:|----------------:| | `default` | 35MiB | 720B | 2.8MiB | 720B | | `git-cliff` | 60MiB | 0B | 19MiB | 0B | | `webnsupdate` | 35MiB | 720B | 2.8MiB | 720B |
jalil merged commit bf8c16f565 into main 2025-01-31 21:21:04 +01:00
jalil deleted branch push-xurxqrnozzrp 2025-01-31 21:21:05 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
chore

Cleanup/trivial updates

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
chore
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
jalil
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jalil/webnsupdate#90
No description provided.
Delete branch "push-xurxqrnozzrp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?