feat: switch to fish as an interactive shell

Now that it is written in Rust I am interested!

modules/hm/default.nix

@@ -58,6 +58,11 @@ in
           git = true;
           icons = "auto";
         };
+        # Shell
+        fish = {
+          enable = true;
+          preferAbbrs = true; # when defining an alias, prefer instead to define an abbreviation
+        };
         # GnuPG
         gpg = {
           enable = true;
@@ -75,16 +80,6 @@ in
         ssh.enable = true;
         # cd replacement
         zoxide.enable = true;
-        # Shell
-        zsh = {
-          enable = true;
-          autosuggestion.enable = true;
-          enableCompletion = true;
-          autocd = true;
-          dotDir = ".config/zsh";
-          history.path = "${config.xdg.dataHome}/zsh/zsh_history";
-          syntaxHighlighting.enable = true;
-        };
       };
 
       services = {

modules/hm/gui/default.nix

@@ -129,11 +129,11 @@ in
       # PDF reader
       zathura.enable = true;
       # Auto start sway
-      zsh.loginExtra =
+      fish.loginShellInit =
-        lib.optionalString cfg.sway.autostart # sh
+        lib.optionalString cfg.sway.autostart # fish
           ''
             # Start Sway on login to TTY 1
-            if [ "$TTY" = /dev/tty1 ]; then
+            if [ $TTY = /dev/tty1 ]; then
               exec sway
             fi
           '';

modules/nixos/default.nix

@@ -35,6 +35,17 @@ in
     ];
 
     programs = {
+      # Launch fish if shell is interactive (from https://wiki.nixos.org/wiki/Fish)
+      bash.interactiveShellInit = # bash
+        ''
+          if [[ $(${pkgs.procps}/bin/ps --no-header --pid=$PPID --format=comm) != "fish" && -z ''${BASH_EXECUTION_STRING} ]]
+          then
+            shopt -q login_shell && LOGIN_OPTION='--login' || LOGIN_OPTION=""
+            exec ${pkgs.fish}/bin/fish $LOGIN_OPTION
+          fi
+        '';
+      # Default shell
+      fish.enable = true;
       # Shell prompt
       starship = {
         enable = true;
@@ -58,8 +69,6 @@ in
           (import ./starship-shorter-text.nix)
         ];
       };
-      # Default shell
-      zsh.enable = true;
     };
 
     environment.etc = keysFromGithub;
@@ -74,7 +83,6 @@ in
         builtins.attrNames keysFromGithub
       );
     };
-    users.defaultUserShell = pkgs.zsh;
     # Open ports for spotifyd
     networking.firewall = {
       allowedUDPPorts = [ 5353 ];

modules/nixvim/dev-plugins.nix

@@ -21,6 +21,7 @@ let
     "typos_lsp"
     # "typst_lsp" # Not using it
     "zls"
+    "fish_lsp"
   ];
 in
 {
@@ -95,6 +96,7 @@ in
           pkgs.stylua
           pkgs.taplo
           pkgs.yamlfmt
+          pkgs.fish
         ];
         plugins.conform-nvim = {
           enable = true;
@@ -111,6 +113,7 @@ in
               toml = [ "taplo" ];
               yaml = [ "yamlfmt" ];
               zig = [ "zigfmt" ];
+              fish = [ "fish_indent" ];
             };
           };
         };
@@ -127,7 +130,6 @@ in
             # latex = [ "chktex" ]; # Not in use
             nix = [ "statix" ];
             sh = [ "dash" ];
-            zsh = [ "zsh" ];
           };
         };
       }

modules/nixvim/plugins.nix

@@ -4,7 +4,11 @@ let
 in
 {
   config.plugins = {
-    cmp = {
+    cmp =
+      let
+        srcWithIndex = groupIndex: name: { inherit name groupIndex; };
+      in
+      {
         enable = true;
         cmdline = {
           "/" = {
@@ -23,9 +27,7 @@ in
             mapping =
               mkRaw
                 # lua
-              ''
+                "cmp.mapping.preset.cmdline()";
-                cmp.mapping.preset.cmdline()
-              '';
             sources = [
               { name = "path"; }
               { name = "cmdline"; }
@@ -36,55 +38,25 @@ in
           # Snippets
           snippet.expand =
             # lua
-          ''
+            "function(args) require('luasnip').lsp_expand(args.body) end";
-            function(args) require('luasnip').lsp_expand(args.body) end
-          '';
           # Completion Sources
           sources = [
-          {
+            # very specific (not noisy)
-            name = "buffer";
+            (srcWithIndex 1 "calc")
-            groupIndex = 3;
+            (srcWithIndex 1 "crates")
-          }
+            (srcWithIndex 1 "fish")
-          {
+            (srcWithIndex 1 "luasnip")
-            name = "calc";
+            (srcWithIndex 1 "nvim_lsp")
-            groupIndex = 2;
+            # Generally ok
-          }
+            (srcWithIndex 2 "conventionalcommits")
-          {
+            (srcWithIndex 2 "nvim_lsp_document_symbol")
-            name = "conventionalcommits";
+            (srcWithIndex 2 "nvim_lsp_signature_help")
-            groupIndex = 1;
+            # Noisy
-          }
+            (srcWithIndex 2 "path")
-          {
+            (srcWithIndex 3 "spell")
-            name = "crates";
+            (srcWithIndex 3 "treesitter")
-            groupIndex = 1;
+            # Very noisy
-          }
+            (srcWithIndex 4 "buffer")
-          {
-            name = "luasnip";
-            groupIndex = 1;
-          }
-          {
-            name = "nvim_lsp";
-            groupIndex = 1;
-          }
-          {
-            name = "nvim_lsp_document_symbol";
-            groupIndex = 1;
-          }
-          {
-            name = "nvim_lsp_signature_help";
-            groupIndex = 1;
-          }
-          {
-            name = "path";
-            groupIndex = 2;
-          }
-          {
-            name = "spell";
-            groupIndex = 2;
-          }
-          {
-            name = "treesitter";
-            groupIndex = 2;
-          }
           ];
           mapping =
             mkRaw
@@ -127,6 +99,7 @@ in
               '';
         };
       };
+    cmp-fish.enable = true;
     gitsigns.enable = true;
     lualine = {
       enable = true;